Attributes GL MR !16: !16

Attributes GL MR !15: !15

Oleksandr Shneyder authored 3 months ago and Mihai Moldovan committed 2 weeks ago

Check the bitmask in ssh_get_status, restart broker timer after proxy is finished and don't assign channelConnection.channel if the channel creation has failed.

Oleksandr Shneyder authored 3 months ago and Mihai Moldovan committed 2 weeks ago

Terminate connection if ssh session was disconnected.

This should prevent crashes if the SSH connection is terminated
unexpectedly.

src/{SVGFrame,contest,cupsprint,help,httpbrokerclient,onmainwindow,print{dialog,widget},pulsemanager,ssh{masterconnection,process},wapi}.cpp: use X2GO_COMPAT_ENDL compat macro.

src/{exportdialog,folder{button,explorer},httpbrokerclient,onmainwindow,session{button,explorer,managedialog,widget},sharewidget,sshmasterconnectioni}.cpp: revert to using macros again.

Unfortunately, it turns out that using aliases are a C++11 feature,
which is not suitable for old systems.

We'll have to resort to macro trickery.

src/{exportdialog,folder{button,explorer},httpbrokerclient,onmainwindow,session{button,explorer,managedialog,widget},sharewidget,sshmasterconnectioni}.cpp: revert to not using compat macros again, code should work out of the box now.

src/compat.h: use new scheme, as shown on github/AD-Vega/qarv#22, which is arguably even better, because it lets us use Qt::... elements all the way!

src/{{share,config}widget,exportdialog,folder{button,explorer},httpbrokerclient,onmainwindow,session{button,explorer,managedialog,widget},sshmasterconnection}.h: revert compat.h inclusion.

src/{exportdialog,folder{button,explorer},httpbrokerclient,onmainwindow,session{button,explorer,managedialog,widget},sharewidget,sshmasterconnectioni}.cpp: use compat macros.

Switch to defining two macros and use these across the base later on.

src/{sharewidget.{cpp,h},configwidget.h}: move compat.h to the very top to see if the scheme actually holds up.

src/folderbutton.cpp: try moving compat.h include down to not pollute the whole Qt namespace with our compat wrapper.

Might need to move it all the way up in order to get this working
correctly, though.